peczenyj / GDPR-IAB-TCFv2 / 25592447867

96%

main: 96%

Pull #109

github

fix: post-release audit (hash-form check + POD alignment)

Audit pass on devel after the v0.400 prep wave. One latent code bug
plus several POD inconsistencies caught while re-reading every module.

Bug fix:
  * `check_publisher_restriction(%hash)` was silently broken: the
    if-branch parsed the named arguments correctly, but a stray
    unconditional list assignment immediately after clobbered the
    lexicals with the literal hash keys. The downstream lookup just
    missed and returned false, so the only existing test
    (`ok !$consent->check_publisher_restriction(...)`) passed by
    accident. Add an `else` and a positive hash-form assertion.

POD alignment:
  * `TO_JSON` example in `TCFv2.pm` SYNOPSIS used `custom_purpose`
    (singular); the actual emitter writes `custom_purposes` (plural).
  * SYNOPSIS verbatim block in `TCFv2.pm` had eight lines unindented,
    breaking out of the code block on metacpan.
  * `Validator.pm` POD documented a constructor key called `strict`,
    but the actual key is `strict_legal_basis` (used in tests and
    SYNOPSIS); spell out that it is forwarded as the `strict` named
    argument to the underlying `is_vendor_*_allowed` calls.
  * `=item*` (no space) in `Constants/Purpose.pm`, plus two
    whitespace-only tab lines after `=head2 ContentProfile` /
    `=head2 ContentSelection`.

No behavior change beyond the hash-form fix. All 17,557 t/ tests pass;
xt/critic, xt/tidy, xt/synopsis pass; podchecker net-improves on
Constants/Purpose.pm (4 -> 2 pre-existing warnings).

1 of 1 new or added line in 1 file covered. (100.0%)

1110 of 1154 relevant lines covered (96.19%)

9202.84 hits per line