kubeflow / trainer / 25578006099
62%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 40
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 61.74% (+3.6%) from 58.174%
25578006099

push

github

web-flow 
chore(test): add unit tests for jobset builder (#3490)

* test: add unit tests for jobset builder

Add comprehensive unit tests for the Builder type methods:
- TestBuilderInitializer: dataset/model initializer env and secret injection
- TestBuilderTrainer: trainer image/command/args/resources application
- TestBuilderPodLabels, TestBuilderPodAnnotations, TestBuilderSuspend

Uses map[string]struct test pattern and go-cmp for assertions,
following established codebase conventions.

Built on top of @upsaurav12's initial work in #3176, with all review
feedback addressed.

Ref #3152

Signed-off-by: Sridhar1030 <sridharpillai75@gmail.com>

* test: add env merge coverage for initializer and trainer builder tests
Address Copilot review feedback on PR #3490:
- Add test case for Dataset.Env merge/upsert in TestBuilderInitializer
- Add test case for Trainer.Env merge/upsert in TestBuilderTrainer
Ref #3152

Signed-off-by: Sridhar1030 <sridharpillai75@gmail.com>

* test: address maintainer review feedback on builder tests

- Consolidate makeJobSetWithInitializer/makeJobSetWithTrainer into single makeJobSet helper
- Add nil Initializer/Trainer spec edge cases (replicas=1, no panic)
- Add MPI runLauncherAsNode + Trainer.Env injection test
- Add multi-replicated-job cases for PodLabels/PodAnnotations
- Add suspend=nil case (unset vs explicit false)

Ref #3152

Signed-off-by: Sridhar1030 <sridharpillai75@gmail.com>

---------

Signed-off-by: Sridhar1030 <sridharpillai75@gmail.com>
Co-authored-by: upsaurav12 <sauravup041103@gmail.com>

2164 of 3505 relevant lines covered (61.74%)

0.71 hits per line

Jobs
ID Job ID Ran Files Coverage
1 25578006099.1 40
61.74
 GitHub Action Run
Source Files on build 25578006099