Ouranosinc / xscen / 25573300694

90%

push

github

Fix for change in parse 1.21 (#729)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #xyz
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?
`parse` 1.21 has added support for the parsing of the grouping character
of decimal numbers. For example `1_000_000` uses `_`. The decoding of
this format spec modifier is done _before_ checking if the requested
format is an "extra" (custom) type. Thus, our custom `_` format was
misinterpreted and our custom regex never applied.

Result : the `{?:_}` pattern matched _anything_. It is supposed to match
everything except slashes `\ /`. This makes `parse_directory` fail to
properly match file names. See the modified test for an example.


I also added a few checks on the (rarely used) decorator that registers
these types.

### Does this PR introduce a breaking change?
No.


### Other information:
@aslibese FYI! I suggest you make sure you have this fix or `parse <
1.21` (1.20.2 works fine) in the environment that builds the catalog!

5 of 7 new or added lines in 1 file covered. (71.43%)

4422 of 4915 relevant lines covered (89.97%)

10.52 hits per line