NodeBB / NodeBB / 25566229153

85%

master: 85%

Build Type

push

github

Committed by web-flow

Commit Message

refactor tests (#14211)

* refactor: break out test/api.js into separate files

* refactor: schema backreference tests so they run in one it block instead of being dynamically generated

* docs: add 'id' and 'core' to values sent by ACP>Settings>Navigation in enabled, ensured that 'enabled.enabled' is always boolean

* fix: break out all IIFEs inside test/api/schema.js into separate internal functions, for organizational purposes

* fix: add 'dropdownContent' to enabled as well

* fix: debug logs

* chore: lint

* test: replaced hardcoded 5s timeout with export file existance polling

* refactor: replace hand-rolled compare() function with sturdier ajv dependency

* fix: remove parts of test/api.js that have been moved to other files

* fix: don't flush db at start of test (assume mocha does this at the end of the last test already

* fix: schema fix

* fix: call setupMockDefaults() instead of flushing db manually

* docs: spec fixes

* fix: update getWatchState so that remote users are default not watching

* fix: spec fixes

* fix: spec fixes, also fix topic thumb and email tests

Coverage Stats

13625 of 18679 branches covered (72.94%)

19 of 20 new or added lines in 11 files covered. (95.0%)

16 existing lines in 3 files now uncovered.

28787 of 33732 relevant lines covered (85.34%)

3338.93 hits per line