stacklok / toolhive / 25552139856

71%

Build Type

push

github

Committed by web-flow

Commit Message

Move pipe and socket URL handling to net/url (#5215)

* Move pipe and socket URL handling to net/url

Replace prefix-and-trim string handling with net/url.Parse on both
the producer (socketURL) and the consumer (HTTPClientForURL,
ParseNamedPipeURL, ParseUnixSocketPath) sides so pipe and socket
addresses round-trip through one library and one set of rules.

socketURL now emits unix:///<path> via (&url.URL{}).String(),
which fixes a real bug on Windows AF_UNIX paths: the previous
concatenation form produced unix://C:\path\thv.sock, which
url.Parse rejects with "invalid port :\\path\\thv.sock". The
round-trip is exercised by new tests on both platforms.

HTTPClientForURL now dispatches on url.Parse + switch u.Scheme,
which gives case-insensitive scheme matching (NPIPE://x routes the
same as npipe://x) for free and matches what the http arm already
does via ValidateLoopbackURL.

ParseNamedPipeURL gains explicit checks that net/url alone cannot
do: a 247-character cap (CreateNamedPipeW's lpName limit minus the
\\.\pipe\ prefix), the legacy reserved Windows device names
(CON, NUL, COM1-9, LPT1-9, ...), and a positive charset of
[A-Za-z0-9._-]+. Names are lowercased via strings.ToLower because
the pipe namespace is case-insensitive at the kernel layer; the
old strings.Contains(name, "..") guard is removed because it
rejected legitimate names like my..api.

ParseUnixSocketPath rejects URLs with non-empty authority, query,
fragment, or userinfo; it also strips the synthetic leading slash
that url.URL inserts in front of Windows drive letters so
unix:///C:%5Cpath%5Cthv.sock round-trips back to C:\path\thv.sock.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Fix Windows AF_UNIX socket URL round-trip

socketURL on Windows for AF_UNIX paths emitted unix://C:%5Cpath%5Cthv.sock
(two slashes) because url.URL.String() only inserts the host/path slash
when Host != "". url.Parse then mis-reads the drive letter as host:port
and returns "invalid port :%5Cpath%5Cthv.s... (continued)

Coverage Stats

36 of 44 new or added lines in 2 files covered. (81.82%)

42 existing lines in 7 files now uncovered.

63362 of 97758 relevant lines covered (64.82%)

60.49 hits per line