bakito / adguardhome-sync / 25547414135

66%

Build Type

push

github

Committed by web-flow

Commit Message

feat(filters): granular sync control for filters (#816)

* feat(filters): granular sync control for blacklist, whitelist, and user rules  Closes #536

feat(filters): granular sync control for blacklist, whitelist, and user rules

Previously, filters were a single boolean feature flag that enabled or
disabled all filter synchronization together. This change breaks it into
three independent sub-flags, allowing users to control blacklist filters,
whitelist filters, and user rules independently.

Changes:
- Add `FiltersType` struct with `BlacklistFilters`, `WhitelistFilters`,
  and `UserRules` fields, replacing the single `Filters bool` field on
  `Features`
- Implement custom `UnmarshalYAML`, `UnmarshalJSON`, and `UnmarshalText`
  on `FiltersType` to maintain full backward compatibility: an existing
  `filters: true/false` scalar config value is automatically expanded to
  set all three sub-fields
- Split `actionFilters` sync logic to respect each sub-flag independently
- Add CLI flags: `--feature-filters-blacklist-filters`,
  `--feature-filters-whitelist-filters`, `--feature-filters-user-rules`
- Deprecate (hide) legacy `--feature-filters` flag; it still works and
  sets all three sub-fields for backward compatibility
- Update `config-schema.json` to accept `filters` as either a boolean
  (legacy) or an object with the three sub-properties
- Fix nil pointer dereference in `ToggleFiltering` call when
  `Enabled`/`Interval` pointers are nil
- Add `documentation` and `env` struct tags to the `Filters` field

Closes #536

* Go Lint Fix

* Repair deprecated flag and catch error

* Update error handling

AI isn't that reliable, huh.

* Add test

* Clarify deprecation message for filters flag

Update the deprecation text for config.FlagFeatureFilters in cmd/run.go to explicitly direct users to the new per-filter flags (--feature-filters-blacklist, --feature-filters-whitelist, --feature-filters-user-rules) instead of the previous vague guidance. This helps user... (continued)

Coverage Stats

61 of 116 new or added lines in 7 files covered. (52.59%)

2 existing lines in 1 file now uncovered.

1975 of 3009 relevant lines covered (65.64%)

0.75 hits per line