Unleash / unleash-node-sdk / 25546605402

90%

Build Type

push

github

Committed by web-flow

Commit Message

fix: correct requests and timeouts on repository, metrics tests (#858)

* fix: unskip test for fetch 404 error

the 404 test's comment claims make-fetch-happen "automatically retries two extra times on 404". Wrong against `node_modules/make-fetch-happen/index.d.ts:62` retries 408, 420, 429, ≥500 and that's it. 404 is not in the list. Un-skip it.

* fix: unskip repository test using polling-fetcher

Tests were skipped because their warn-message assertion is stale. They expect responded 502. Waiting for 20ms before trying again. but `polling-fetcher.ts:91-95` emits responded `${statusCode}. Backing off` (matching the live 500 test on line 380).

* fix: unskip test and correct sendMetrics() failing behavior

The test at src/test/metrics.test.ts:417-456 verifies that when an HTTP 500 is returned, the bucket metrics are preserved so nothing is lost. We were skipping this test even though it is useful. It was failing because of a race condition in the event-emission order inside sendMetrics().

Move `restoreBucket()` and `metricRegistry?.restore()` to before `configurationError()` / `backoff()`, so the bucket is restored before any warn/error event fires and potentially disables the instance.

* fix: correct test timeouts on sendMetrics()

* fix: skip tests repository - leave them as TODOs

Coverage Stats

669 of 787 branches covered (85.01%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

1242 of 1327 relevant lines covered (93.59%)

5255.13 hits per line