daycry / auth / 25545938245

72%

Build Type

push

github

Committed by daycry

Commit Message

Drop redundant ?? defaults on non-nullable Auth config properties

PHPStan strict-rules on PHP 8.5 (CI) flagged three `??` operators
applied to properties whose declared type is non-nullable, so the
right-hand side is unreachable code:

- Auth::$gateAutoDiscover  (bool,   default true)
- Auth::$policyNamespace   (string, default 'App\Policies\')
- Auth::$basicAuthRealm    (string, default 'Restricted')

The ?? was a defensive habit from earlier code that read settings via
`setting('Auth.foo')` (which can legitimately return null when not
overridden). For typed properties on the Config class itself the
default is always applied, so `??` is dead code.

Files fixed:
- src/Authorization/Gate.php — autoDiscoverPolicy() reads $gateAutoDiscover
  and $policyNamespace directly. Stashed `config('Auth')` in a local
  to avoid two lookups.
- src/Filters/BasicAuthFilter.php — challenge() reads $basicAuthRealm
  directly.

PHPUnit and the local PHPStan run remain green; this commit makes the
CI PHPStan job (which runs on PHP 8.5) green again too.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

1 of 4 new or added lines in 2 files covered. (25.0%)

1 existing line in 1 file now uncovered.

3672 of 6220 relevant lines covered (59.04%)

48.17 hits per line