umputun / revdiff / 25536024285

90%

push

github

feat: in-session search history recall (#171)

* add plan: search-history

* feat: add in-session search history recall

Up/Ctrl+P walks backward through past search queries, Down/Ctrl+N walks
forward. Down past the newest entry clears the input. History is
in-memory only with a 50-entry cap and consecutive-duplicate dedup.

* feat: verify search history acceptance criteria

Validates Task 2 acceptance gates from the search-history plan.
Modernizes recallHistory clamp logic to use min/max builtins and
range-over-int loop in the cap-enforcement test.

* feat: document in-session search history keybindings

Add Up/Ctrl+P and Down/Ctrl+N rows to the search keybindings tables in
README.md, site/docs.html, and the two byte-identical usage.md copies in
.claude-plugin/ and plugins/codex/. Move the search-history plan file to
docs/plans/completed/.

* fix: address code smell findings

Refactor appendSearchHistory to a single exit path so the historyIdx
reset isn't duplicated across the dedup early return and the append
path. Trim two test assertion messages that exceeded the 130-char
guideline. Replace the deprecated reflect.Ptr alias with reflect.Pointer
in isNilValue.

* feat: surface search history keys in help overlay

inject Up/Ctrl+P and Down/Ctrl+N entries into the existing Search
section of the help overlay so users can discover the in-prompt
recall keybindings without reading the README.

* chore: modernize backward slice loops to slices.Backward

replace 9 backward for-loops with slices.Backward iterators across
app/themes.go, app/ui/annotate.go, app/ui/diffnav.go, app/ui/view.go,
and app/ui/sidepane/filetree.go. clears modernize linter findings.
no behavior change.

* fix: address code review findings

52 of 52 new or added lines in 8 files covered. (100.0%)

9657 of 10763 relevant lines covered (89.72%)

3203.46 hits per line