roundup-tracker / roundup / 25532790014

75%

Build Type

push

github

Committed by rouilj

Commit Message

bug: issue2551405 - locale error causes 500 code uwsgi with no log

Changed exception handling in two places.

There is an inner try/except where I added the more specific
ConnectionAbortedError before the existing IOError
exception. ConnectionAbortedError should be what is returned (in
python 3) when writing on a closed connection caused by the client
going away. Unable to test though.

Then I set up IOError to log/report exception as it is
unexpected. This logs useful error for the issue.

In the outer try/except, I replaced outer IOError handler with
ConnectionAbortdError handler. Then I removed IOError handler and let
an IOError fall through the last resort exception handler.

For this specific translator issue, generating the html error message
also crashes because it is trying to translate it and translation
fails. So I wrap the cgitb.http call in try/except Exception and
logger.exception() the original exception so there is something useful
logged.

Coverage Stats

2 of 21 new or added lines in 1 file covered. (9.52%)

11 existing lines in 2 files now uncovered.

19180 of 25656 relevant lines covered (74.76%)

4.4 hits per line