divviup / divviup-api / 25528517822

69%

Build Type

push

github

Committed by web-flow

Commit Message

Migrate from Trillium [part 7B]: aggregators and tasks (#2246)

Migrate all aggregator and task routes from Trillium to Axum. These are
the "hard handlers" — they make outbound HTTP calls to DAP aggregator
services via trillium_client::Client.

Notable changes:
- Split aggregators::index into index_shared (GET /api/aggregators) and
  index_for_account (GET /api/accounts/{id}/aggregators) instead of
  checking conn.param("account_id") at runtime
- admin_create checks actor.is_admin() inline, returns NotFound for
  non-admins (matching existing behavior of hiding admin endpoints)
- tasks::delete uses Query<DeleteParams> instead of QueryStrong for the
  ?force=true parameter
- tasks::show uses httpdate for Last-Modified header

That change to the `force` query makes it strict: before, any unparseable value
(e.g. ?force=garbage, ?force=) silently became false, while now if it's not a bool,
serde is going to error it out. I think that's an improvement, but I want to call
it out.

The Trillium router now contains only admin routes. All Trillium handler
functions for aggregators and tasks are removed. Test assertions updated
from assert_not_found to assert_response 403 for routes that now go
through the Axum extract_entity / FromRequestParts path.

Coverage Stats

210 of 212 new or added lines in 6 files covered. (99.06%)

42 existing lines in 6 files now uncovered.

4510 of 7701 relevant lines covered (58.56%)

65.62 hits per line