daycry / auth / 25516015137

72%

push

github

Apply Rector targeting PHP 8.2 across src/ and tests/

CI runs Rector with a fresh cache on every push; my local runs were
hiding 28 files of pending refactors behind /tmp/rector. Bumping
phpVersion(PHP_82) on top of that surfaced them all at once. The
applied fixes are mechanical, no behaviour change:

- catch (Exception $e)  ->  catch (Exception)
  When the variable was never used. PHP 8.0+ allows it; Rector's
  RemoveUnusedVariableInCatchRector was the dominant rule (≈20 files,
  almost every Migration constructor, Controllers, Filters).
- Promoted private $table on every Migration class to readonly via
  PrivatizeFinalClassPropertyRector. The constructor sets it once and
  it never changes.
- NullToStrictStringFuncCallArgRector: cast strings before passing them
  to native functions whose signatures changed in 8.x.
- Drop unused `use CodeIgniter\HTTP\Response;` flagged by no_unused_imports
  on EmailActivator after the rewrite.

Tests + PHPStan + Deptrac + PHPCPD all green; PHPUnit assertion count
unchanged (1373).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

12 of 31 new or added lines in 17 files covered. (38.71%)

3544 of 6047 relevant lines covered (58.61%)

47.97 hits per line