GrottoCenter / grottocenter-api / 25515043879

87%

develop: 87%

Build Type

Pull #1564

github

Committed by ClemRz

Commit Message

fix(entrance): resolve permanent delete FK violations and preserve audit history

- Parallelize sub-entity deletes for ~100x performance improvement
- Make notification fire-and-forget to unblock response
- Fix FK violations: clean up exit references, junction tables, and
  history table FKs using raw SQL (Waterline silently fails on
  composite-PK models)
- Preserve h_ rows for auditability instead of deleting them
- Add SQL migration to drop h_* parent FK constraints that block
  permanent deletes (aligns dev/test with production behavior)
- Add structured audit logging with entity IDs
- Add comprehensive auditability test covering all entity types,
  junction tables, and cave cascade
- Fix cave delete: use raw SQL for junction cleanup, fire-and-forget
  notifications, parallelize operations
- Extract subEntityDelete to module scope, fix entranceId type coercion

Pull Request Pull Request #1564: fix(entrance): resolve permanent delete FK violations and preserve audit history

Coverage Stats

3038 of 3628 branches covered (83.74%)

Branch coverage included in aggregate %.

34 of 37 new or added lines in 4 files covered. (91.89%)

2 existing lines in 1 file now uncovered.

6260 of 7075 relevant lines covered (88.48%)

53.7 hits per line