Qiskit / qiskit / 25510783043

88%

Build Type

push

github

Committed by web-flow

Commit Message

Split `bindgen` simplified IR from parse/export logic (#16144)

While starting to write a Rust/PyO3 raw-FFI backend for the C API via
the Python package, I realised that a lot of the logic was about to be
duplicated from the `ctypes` output.  Had I realised this sooner, I'd
have folded this commit into ae919867[^1] to avoid an immediate refactor.

I've not attempted to de-duplicate _all_ logic that ever might occur
(for example, lifting a `Function` is going to look _mostly_ similar but
not identical), because there's enough little tweaks between the
languages to make the abstraction awkward, and we're unlikely to have
enough languages to really warrant it.  For example, the `ctypes`
binding needs to know that any custom "path" name of an `Enum` can't
actually be exported to that name, because we use Python-space true
`Enum` classes in the `ctypes` bindings for input.  This restriction
isn't present in other languages.

[^1]: ae919867: Add auto-generated `ctypes` bindings to C API (gh-16067)

Coverage Stats

185 of 194 new or added lines in 3 files covered. (95.36%)

5 existing lines in 2 files now uncovered.

106992 of 122093 relevant lines covered (87.63%)

960702.12 hits per line