safe-global / safe-client-gateway / 25508941613

90%

main: 90%

Pull #3079

github

docs(engineering): add CGW conventions manual with rules and examples

Introduces a structured engineering convention manual under docs/engineering
to capture and apply CGW-local code-review patterns:

- rules.json + rules.schema.json: 59 durable pre-PR rules across modules,
  types, auth, database, cache, config, tests, performance, logging,
  security, and resilience. Each carries a stable rule ID, area, durable
  rule, executable check, exampleRefs, and reviewLearningIds.
- rules.generated.md: human-readable view, regenerated from rules.json.
- examples/: 12 topic files (testing, schemas-and-validation, cache,
  database-migrations, repositories-and-pagination, controllers-and-swagger,
  error-handling, auth-and-secrets, style, scope-and-pr-hygiene, resilience,
  configuration). Each Avoid/Prefer/Why block traces back to its source
  PR and review-learning ID.
- working/review-learnings.json + schema: 31 review learnings distilled
  from CGW PR review feedback (CLOSED-20251211 through CLOSED-20260205).
  Every CLOSED-* learning carries the originating reviewCommentIds /
  reviewIds / issueCommentIds for traceability.
- working/review-learning-ledger.json: covered-range state for the
  safe-engineering:code-conventions skill.
- README.md and project-structure.md: routing and placement guide.
- .gitignore: ignore docs/engineering/pr-self-review-checklist.generated.md
  produced by the PR-review checklist generator.

4202 of 5063 branches covered (82.99%)

Branch coverage included in aggregate %.

16068 of 17540 relevant lines covered (91.61%)

568.49 hits per line