bosonprotocol / boson-protocol-contracts / 25502157316

98%

push

github

Feat/orchestration commit and redeem (#1105)

* Add atomic commit-and-redeem orchestration methods

Adds three new methods on OrchestrationHandlerFacet2 that bundle the
commit and redeem steps into a single transaction:

- commitToOfferAndRedeemVoucher(offerId)
- commitToConditionalOfferAndRedeemVoucher(offerId, tokenId)
- createOfferCommitAndRedeem(fullOffer, offerCreator, signature, tokenId)
  (seller-created offers only; reverts otherwise with OfferCreatorMustBeSeller)

The committer is hardcoded to _msgSender() so the redeem step's voucher-holder
check always passes. Bundled twins are transferred to _msgSender() during the
redeem leg, mirroring the standalone redeemVoucher behavior.

To share logic without breaching the 24KB facet size limit, two new bases
were introduced:

- ExchangeRedeemBase: redeemVoucherInternal, burnVoucher, transferTwins,
  updateNFTRanges. ExchangeHandlerFacet now inherits it and overrides
  _computeBurnTokenId to keep pre-2.2.0 voucher token-id support.
- ExchangeCommitBase: commitToOfferInternal, verifyOffer, authorizeCommit,
  holdsThreshold/holdsSpecificToken, validateConditionRange,
  handleDRFeeCollection, addSellerParametersToBuyerOffer.
  ExchangeCommitFacet now inherits it.

OrchestrationHandlerFacet2 inherits both bases and the new methods reuse
the shared internals directly.

* Deduplicate commit-and-redeem orchestration vs. the public commit methods

Three new internal helpers in ExchangeCommitBase capture the validation +
commit logic that was previously duplicated between the public commit
entry points and their commit-and-redeem orchestration counterparts:

- commitToStaticOfferShared: getValidOffer + Static check + no-condition
  check + commitToOfferInternal. Used by commitToOffer (public) and
  commitToOfferAndRedeemVoucher (orchestration).
- commitToConditionalOfferShared: same shape with condition fetch +
  validateConditionRange + authorizeCommit + commit + condition snapshot.
  Takes an _allowBuyerCre... (continued)

1881 of 1964 branches covered (95.77%)

Branch coverage included in aggregate %.

283 of 283 new or added lines in 5 files covered. (100.0%)

3300 of 3300 relevant lines covered (100.0%)

1246.66 hits per line