stacklok / toolhive-studio / 25499315956

68%

main: 71%

Build Type

Pull #2207

github

Committed by samuv

Commit Message

fix(playground): defer empty thread persistence until first message

Visiting /playground or clicking + New chat used to call createChatThread() over IPC, which immediately wrote an empty thread row to SQLite even when the user never ended up sending a message. Every fresh session leaked one (or more) empty threads into the DB, and the row was indistinguishable from a real conversation in the sidebar / on reload.

Generate the thread id in the renderer and only promote the draft to a real DB row when the user submits the first message. A new thread-id util produces ids with the same thread_<ts>_<rand> shape the main process uses, so drafts are visually identical to persisted ids in the URL and sidebar. playground.index.tsx's beforeLoad resolver now redirects to a locally-generated id instead of calling createChatThread() when no DB threads exist.

usePlaygroundThreads tracks drafts in renderer state with a pending: true flag so the sidebar still renders them as normal items. createThread() reuses an existing empty draft instead of piling up new ones on repeated + New chat clicks, and deleteThread short-circuits the IPC for drafts (which would otherwise return 'Thread not found' and block the navigation away).

useChatStreaming.validatedSendMessage awaits ensureThreadExists(currentThreadId) before calling sendMessage, so the row exists by the time runManagedStream starts writing snapshots via updateThreadMessages. Promotion failure short-circuits the send with a thrown error.

Drafts intentionally do not survive an app reload — acceptable for a chat the user never committed to. setActiveThreadId(draftId) is left as-is: main stores the id but the index resolver validates it against getAllThreads() on the next visit and falls back. Tests updated for the index route, usePlaygroundThreads (draft generation, draft reuse, pending-draft delete), and useChatStreaming (ensureThreadExists ordering + failure short-circuit).

Pull Request Pull Request #2207: fix(playground): defer empty chat thread persistence until first message

Coverage Stats

4690 of 7457 branches covered (62.89%)

25 of 26 new or added lines in 6 files covered. (96.15%)

1 existing line in 1 file now uncovered.

7005 of 10326 relevant lines covered (67.84%)

120.88 hits per line