decentraland / comms-message-sfu / 25499031545

90%

main: 90%

Build Type

Pull #113

github

Committed by LautaroPetaccio

Commit Message

fix: guard publishData against non-connected Room

A recent dev SIGSEGV happened inside @livekit/rtc-node native code
during the SDK's internal reconnect. Independently, there is a
latent race in routeMessage where an in-flight routing call can
outlive a concurrent disconnect and end up invoking publishData on
a Room whose native state is being torn down — which can crash the
process.

Add a ConnectionState check before each publishData so we bail
cleanly (logged + failed metric) instead of touching torn-down
native handles.

Also bump @livekit/rtc-node ^0.13.14 -> ^0.13.27, which brings in
upstream fixes around FFI event ordering, waiting for the disconnect
response, and native handle disposal — all in the same crash class.

Switch @dcl/protocol to the experimental dist-tag so we keep
tracking the experimental branch where Chat.forwarded_from lives;
main dropped that field.

Pull Request Pull Request #113: fix: guard publishData against non-connected Room

Coverage Stats

64 of 77 branches covered (83.12%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

259 of 284 relevant lines covered (91.2%)

8.99 hits per line