safe-global / safe-client-gateway / 25493180951

90%

Build Type

push

github

Committed by web-flow

Commit Message

fix: restore runtime imports for @ApiProperty class types (#3080)

The Biome 2.0 migration (#3030) auto-converted runtime-needed class
imports to `import type { ... }`. With `emitDecoratorMetadata: true`,
type-only imports are erased before TS emits `Reflect.metadata`, so
@ApiProperty()-decorated fields lost their constructor reference and
the OpenAPI generator wrote a generic `Function` placeholder for
NativeCurrency, RpcUri, BalancesProvider, AddressInfo, TokenInfo,
DataDecoded, Transaction, TransactionData, ProtocolMetadata,
ExecutionInfo, SafeAppAccessControl, etc. — corrupting the schema
consumed by safe-wallet-monorepo (`@safe-global/store` AUTO_GENERATED).

Switch the affected imports to the dual-import pattern already used by
GasPriceOracle/GasPriceFixed in chain.entity.ts:
  import { Foo as ApiFoo, type Foo } from '...';

`useImportType` is already off in biome.json, so the fixes will not
auto-revert. viem string-branded aliases (Address, Hash, Hex) and
Zod-inferred types stay as `import type` since they have no runtime
representation.

Coverage Stats

4202 of 5063 branches covered (82.99%)

Branch coverage included in aggregate %.

35 of 35 new or added lines in 30 files covered. (100.0%)

1 existing line in 1 file now uncovered.

16047 of 17535 relevant lines covered (91.51%)

569.13 hits per line