nats-io / nats.go / 25487621688

85%

Build Type

push

github

Committed by web-flow

Commit Message

[FIXED] Subscription.StatusChanged channel closure on Closed Subscription (#2034)

The Subscription.StatusChanged godoc mentions that the returned channel
will be closed when the subscription is closed. However, this is the
case only if the subscription is closed after the StatusChanged channel
is created and registered to listen for changes.

To prevent consumers from waiting on signals from closed subscriptions,
lets close the channel if the current status of the Subscription is
already SubscriptionClosed. If the consumer is subscribing to
SubscriptionClosed, we send this status on the channel before closing
the channel for backwards compatibility.

Signed-off-by: Nithilan Manimaran Pugazhendhi <nithilan.pugazhendhi@imc.com>

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

11 existing lines in 1 file now uncovered.

14747 of 17248 relevant lines covered (85.5%)

32945.38 hits per line