2506081045
81%
master: 81%

Ran 07 May 2026 02:43AM UTC

Jobs 1

Files 133

Run time 1min

Badge

Embed ▾

Committed 07 May 2026 02:30AM UTC coverage: 81.442%. Remained the same

Build # 2506081045

Build Type

push

gitlab-ci

Committed by

lhoward

Commit Message

fix: common/error: include <ostream> for operator<<(ostream&, string&)

src/common/error.cpp defines

    std::ostream &operator<<(std::ostream &os, const Error &err) {
        os << err.String();
        ...
    }

err.String() returns std::string, so this relies on the free
function operator<<(std::ostream&, const std::string&) being a
complete definition at the call site, not just a forward declaration.

error.cpp only includes <common/error.hpp>, which in turn includes
<string> and <system_error>. Under libstdc++ that chain happens to
drag in the full body of the string ostream operator, so the call
gets inlined and the link succeeds. Under libc++, <string> only
provides a forward declaration (marked _LIBCPP_HIDE_FROM_ABI); the
body lives in <ostream>/<__ostream/basic_ostream.h>. Without that
include, the compiler emits an out-of-line call to a hidden-
visibility symbol that never gets defined and the link fails:

  undefined reference to 'std::operator<<[abi:...]<char, ...>(
    basic_ostream<char,...>&, const basic_string<char,...>&)'

Include <ostream> explicitly so the definition is reachable regardless
of which C++ standard library is in use.

Changelog: none
Signed-off-by: Luke Howard <lukeh@padl.com>

Coverage Stats

9185 of 11278 relevant lines covered (81.44%)

20238.44 hits per line

Coverage Regressions

Lines	Coverage	∆	File
1	80.57	-0.47%	src/mender-update/update_module/v3/update_module_download.cpp

Jobs

ID	Job ID	Ran	Files	Coverage
1	2506081045.1	07 May 2026 02:43AM UTC	133	81.44

mendersoftware / mender / 2506081045
81%
master: 81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 2506081045

mendersoftware / mender / 2506081045 81% master: 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 2506081045

mendersoftware / mender / 2506081045
81%
master: 81%

README BADGES
x