samsarahq / taskrunner / 25466778043

40%

Build Type

push

github

Committed by johnwonkim

Commit Message

Revert "taskrunner goextensions: use specific dependencies for tasks"

This reverts commit <a class=hub.com/samsarahq/taskrunner/commit/eb5f1b5713c9e6f80789be677736758dcaba72bb">eb5f1b571<a href="https://github.com/samsarahq/taskrunner/commit/5544f98d5fa844be49dc2b5308dd0cc04754feda">.

The original intention for this commit was to fix invalidations from
being too eager by adding specific glob sources rather than a blanket
wildcard go file change. This resulted in each service task getting
around 2000 individual sources to check over. The file watcher runs
a regex check: `zglob.Match(source, path)` for every single source,
every time a file gets saved. Multiply this by our 50+ tasks, and
you start to see strange behavior regarding invalidations including:
- invalidations being super slow (10 seconds to 2 mins)
- invalidations being soooo slow that we question whether they dropped
- invalidations being fast on taskrunner start, slow after

How did i test?
___
I ran backend with various pinned versions of taskrunner, and triggered
invalidations by saving the `userpreferencesservice/main.go` file with
garbage changes to trigger syntax errors.

Expected: File changes should trigger invalidations quickly

Taskrunner versions:
- current master samsarahq/taskrunner version (broken)
  - `<a class="double-link" href="https://github.com/samsarahq/taskrunner/commit/b7f09d6666d7e4bd45ab593d2eba2426b62f5fee">b7f09d666</a><a href="https://github.com/samsarahq/taskrunner/commit/5544f98d5fa844be49dc2b5308dd0cc04754feda">`
  - invalidations trigger slowly, or not at all
- current pinned revert version living on backend (working)
  - `</a><a class="double-link" href="https://github.com/samsarahq/taskrunner/commit/cef65c91d3fe6529ac9d1b3330c4f968f6f857cd">cef65c91d</a>`
  - invalidations trigger within seconds
- Sources depdendency graph change (breaking root cause)
  - `eb5f1b5713c9e6f80789be677736758dcaba72bb`
  - invalidations trigger slowly, or not at all
- New proposed working fix (working)
  - this commit
  - invalidations trigger within seconds

I explored the possibility of fixing this commit and rather than
full on reverting it. However, I was reaching the end of my timebox, so
i decided to go with a revert here.

Coverage Stats

0 of 25 new or added lines in 1 file covered. (0.0%)

114 existing lines in 1 file now uncovered.

791 of 2068 relevant lines covered (38.25%)

3.46 hits per line