peczenyj / GDPR-IAB-TCFv2 / 25465081412

96%

main: 96%

push

github

Phase 2: The Validator Interface (rebased + reviewed) (#54)

* Phase 2: The Validator Interface

* Refactor Validator to reduce complexity (fix perlcritic)

* Phase 2: review fixups for the Validator interface

Three must-fix changes plus expanded test coverage that came out of
the deep review on PR #35:

  * Encapsulation: _check_disclosed used to reach into the parser's
    private hash (\$tc->{disclosed_vendors_data}).  Replace with the
    public predicate \$tc->has_vendor_disclosure (added in Phase 1).

  * Test regex bug (t/06-validator.t):
        qr/purpose 1.* | .*purpose 7/
    has an unescaped pipe inside qr//, so it parsed as alternation
    rather than a literal " | " separator.  The test passed even
    when the \$\\-aware joining didn't work, leaving the headline
    feature unverified.  Fix:
        qr/purpose 1.*\\Q | \\E.*purpose 7/

  * POD: previously zero documentation.  Phase 1 set the bar; add
    full POD for both modules with SYNOPSIS, DESCRIPTION, every
    constructor key, both methods, the boolean/stringification
    overloads, and the \$\\-aware separator behaviour.

Test coverage added for previously-uncovered paths:

  * Pre-parsed GDPR::IAB::TCFv2 object as input
  * Missing vendor_id (croak) plus override fill-in
  * legitimate_interest_purpose_ids (pass + spec-forbidden P1)
  * flexible_purpose_ids scalar form
  * flexible_purpose_ids hashref form (both default_is_li values)
  * strict-mode override (warn path via Test::Warn + croak path)
  * validate_all accumulating reasons across all three rule families

MANIFEST: add lib/GDPR/IAB/TCFv2/Validator.pm,
lib/GDPR/IAB/TCFv2/Validator/Result.pm, and t/06-validator.t
(missing from the original Phase 2 commits).

t/06-validator.t now has 11 subtests (was 4); 8287 tests pass
overall (was 8280).  perlcritic + perltidy clean.

* refactor(validator): derive flexible-purpose default basis from membership

flexible_purpose_ids is now a flat ArrayRef[Int].  The default
legal basi... (continued)

174 of 200 new or added lines in 3 files covered. (87.0%)

908 of 964 relevant lines covered (94.19%)

9367.54 hits per line