25464229953
57%
master: 55%

Ran 06 May 2026 10:18PM UTC

Jobs 4

Files 282

Run time 1min

Badge

Embed ▾

Committed 06 May 2026 10:16PM UTC coverage: 56.916% (+0.6%) from 56.339%

Build # 25464229953

Build Type

push

github

Committed by

starius

Commit Message

tests: fix stale regtest assumptions after #2467

PR #2467 changed regtest to match Core's BIP34/65/66 activation rules, and
the merged stack carries that (commit cd4e5426 "regtest: align activations
with Bitcoin Core"). Height-1 regtest blocks now need a BIP34-compliant
coinbase height and a post-BIP66 block version.

The failing tests came from commits added after PR #2467 was opened on
December 25, 2025 but before it merged on April 30, 2026:

- c1a46122 ("blockchain: add ProcessBlockHeader")
- f9645f07 ("blockchain: reuse existing header node in maybeAcceptBlock")
- dc6e096c ("netsync: add TestSyncStateMachine for end-to-end IBD sync flow")
- ce094262 ("netsync: add TestStartSyncBlockFallback for block-only sync path")
- 2aae8a6d ("netsync: add TestStartSyncChainCurrent for chain-current noop path")

Because those tests landed later, they kept the old regtest assumptions even
though #2467 had already been authored and tested against the older tree.
Once #2467 finally merged, these newer tests started building invalid regtest
blocks and headers.

Fix them by setting the genesis tip height to 0 before generating descendants,
using Version 4 in the regtest block/header helpers, and encoding the test
coinbase height with a minimal BIP34 push plus padding for the generic coinbase
script-length rule.

Coverage Stats

32373 of 56879 relevant lines covered (56.92%)

438343.77 hits per line

Coverage Regressions

Lines	Coverage	∆	File
327	17.22	1.18%	rpcclient/chain.go
94	90.22	-0.09%	blockchain/fullblocktests/generate.go
74	89.19	4.96%	blockchain/validate.go
46	92.16	5.3%	txscript/engine.go
34	0.0	0.0%	cmd/btcctl/config.go
18	80.41	1.07%	wire/message.go
18	88.52	9.56%	wire/netaddressv2.go
17	86.51	5.69%	txscript/standard.go
9	98.28	-0.21%	txscript/opcode.go
6	75.23	0.47%	database/ffldb/dbcache.go
3	89.93	0.42%	txscript/script.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	btcutilpsbt - 25464229953.1	06 May 2026 10:18PM UTC	98	21.79	GitHub Action Run
2	btcutil - 25464229953.2	06 May 2026 10:18PM UTC	120	18.86	GitHub Action Run
3	btcec - 25464229953.3	06 May 2026 10:18PM UTC	18	80.52	GitHub Action Run
4	btcd - 25464229953.4	06 May 2026 10:18PM UTC	250	51.53	GitHub Action Run

starius / btcd / 25464229953
57%
master: 55%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 25464229953

starius / btcd / 25464229953 57% master: 55%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 25464229953

starius / btcd / 25464229953
57%
master: 55%

README BADGES
x