stacklok / toolhive / 25463881983

65%

push

github

Add Redis Cluster mode support to auth server storage (#5153)

* Add Redis Cluster mode support to auth server storage

Managed Redis services like GCP Memorystore Cluster and AWS ElastiCache
Serverless use the Redis Cluster protocol rather than standalone or Sentinel
connections, making it impossible to use them without this third mode.

- Add ClusterConfig/ClusterRunConfig types to storage and runner layers
- Wire cluster client creation via redis.NewClusterClient in NewRedisStorage
- Update validateConfig, convertRedisRunConfig, and buildStorageRunConfig to
  enforce three-way mutual exclusion (addr / sentinel / cluster)
- Add RedisClusterConfig CRD type with MinItems=1 validation; update CEL rule
  to require exactly one of the three modes
- Regenerate deepcopy, CRD YAML, and Helm chart templates
- Add unit tests for all new validation and happy-path code paths

Closes #5010

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Simplify Redis Cluster mode to addr + clusterMode bool

ClusterConfig{Addrs []string} was a misleading abstraction: GCP Memorystore
Cluster and AWS ElastiCache cluster mode both expose a single discovery endpoint,
so the slice always held exactly one address and was redundant with the existing
Addr field.

Replace ClusterConfig with a ClusterMode bool flag that is set alongside the
existing Addr field. go-redis NewClusterClient still receives the single endpoint
as []string{addr} and auto-discovers the full cluster topology from there.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Regenerate Swagger docs for cluster_mode field

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Regenerate CRD API reference docs for clusterMode field

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

39 of 41 new or added lines in 3 files covered. (95.12%)

63164 of 97491 relevant lines covered (64.79%)

58.6 hits per line