Alan-Jowett / sonde / 25458938030

81%

push

github

Support Windows Azure companion bootstrap (#851)

* Support Windows Azure companion bootstrap

Keep manual Windows ootstrap aligned with the Azure companion specs by replacing the Unix-only private-key write guard with a secure Windows ACL-based creation path, and add Windows coverage for certificate generation plus runtime service key access expectations.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix Azure companion formatting

Run rustfmt over the Windows bootstrap changes so cargo fmt --check --all passes in CI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Address PR review feedback

Make the Windows wide-string helper stop accepting nullable raw pointers and add an end-to-end ACL inspection test for the generated private key so the PR's security contract is checked against the on-disk DACL.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix unaligned Win32 buffer reads

Address the remaining PR #851 review feedback by avoiding aligned dereferences of Win32 data returned into byte buffers. Use read_unaligned for TOKEN_USER and QUERY_SERVICE_CONFIGW while keeping the backing buffers alive for interior pointers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

32 of 32 new or added lines in 1 file covered. (100.0%)

33591 of 40455 relevant lines covered (83.03%)

198.05 hits per line