wboayue / rust-ibapi / 25455609826

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(messages): proto-aware request_id/order_id/execution_id (#519)

* fix(messages): proto-aware request_id/order_id/execution_id

For server_version >= PROTOBUF, peek_string panicked on CommissionsReport
proto messages (fields=[msg_id]); order_id/request_id silently returned None,
breaking subscription routing for OpenOrder/OrderStatus/ExecutionData.

- request_id/order_id/execution_id now proto-aware via proto_or_text_{int,string}
  helpers
- order_id handles per-message-type proto layout (tag 1 vs nested
  execution.order_id for ExecutionDetails)
- peek_string returns Result, matching peek_int/peek_long
- place_order example now actually uses --buy/--sell flags (were ignored)

End-to-end smoke (paper gateway): OpenOrder -> OrderStatus -> ExecutionData ->
CommissionReport all routed to subscription.

* review follow-ups: drop routing duplication + migration note + tests

- transport/routing.rs: drop RoutingEnvelope + protobuf_first_int. Now that
  ResponseMessage::{order_id,request_id} are proto-aware, determine_routing
  collapses into a single text/proto-shared dispatch. Notably this also fixes
  the latent ExecutionData heuristic — text path used the nested order_id,
  proto path was using protobuf_first_int which returned req_id at tag 1.
- docs/migration-3.0.md: §6 covers peek_string Result return-type change.
- messages/tests.rs: defensive test for is_protobuf=true with raw_bytes=None.
- transport/routing_tests.rs: 6 new tests exercising determine_routing with
  proto-form OpenOrder/OrderStatus/ExecutionData (nested order_id) /
  ExecutionDataEnd / CommissionsReport / AccountSummary. Regression guard
  for the bug class fixed by this PR.

* simplify: minimal proto envelopes, drop test boilerplate

Hot path: order_id()/execution_id() were doing full prost::Message::decode of
OpenOrder / OrderStatus / ExecutionDetails per inbound message just to read a
single int32 or String. After this commit:

- OpenOrder, OrderStatus, ExecutionDataEnd: read o... (continued)

Coverage Stats

43 of 45 new or added lines in 3 files covered. (95.56%)

1 existing line in 1 file now uncovered.

17595 of 19969 relevant lines covered (88.11%)

26.76 hits per line