dcdpr / jp / 25451297170

66%

Build Type

push

github

Committed by web-flow

Commit Message

fix(attachment): reject path-absolute hostless URI shortforms (#617)

Both `bear:/NOTE_ID` and `gh:/pull/N/diff` parse as hierarchical
(non-opaque) URLs with no authority — a distinct shape from the truly
opaque shorthands `bear:NOTE_ID` and `gh:pull/N/diff`. Previously the
fallback branch silently accepted them, mapping them to the shortform
despite being undocumented variants.

The fix gates the opaque-shortform branch on `cannot_be_a_base()`, which
is only true for truly opaque URLs. Path-absolute hostless forms now
fall through to the error arm with an explicit message. Tests are added
for both handlers to pin the rejection.

Also removes the unscoped `git config --get user.name` fallback in
`detect_default_user_name()` (`jp init`): the unscoped lookup resolves
against whichever repo is in cwd, leaking a repo-local identity the user
explicitly chose not to make global into every future JP workspace. Only
the `--global` form and `$USER`/`$USERNAME` are retained.

The internal `web/fetch` HTML parser gains support for the
`<dt><dt><dd>` shared-definition group shape, where several terms share
one `<dd>`. Fetching any term in the group now returns the whole group,
and the `list_sections` summary and `web_fetch.toml` descriptions are
updated to reflect that definition-list terms are surfaced alongside
headings.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

26 of 32 new or added lines in 4 files covered. (81.25%)

2 existing lines in 1 file now uncovered.

25603 of 38711 relevant lines covered (66.14%)

224.07 hits per line