stacklok / toolhive / 25449151925

65%

Build Type

push

github

Committed by web-flow

Commit Message

Install local skill builds by name when tag differs (#5182)

* Extract local-build install opts hydration helper

Pull the LayerData/Digest/Reference/Version assignment block out of resolveFromLocalStore into a small hydrateOptsFromLocalBuild helper so a follow-up can share it between the existing direct-tag path and a new local-build name-scan path. No behavior change.

* Resolve local skill builds by name when tag differs

A local skill build tagged with something other than its declared skill name (e.g. thv skill build --tag v0.0.1) was not findable via POST /api/v1beta/skills with a plain name + version body: install-by-name did a literal tag lookup against the local OCI store, so the only resolvable handle was the OCI tag string. Callers got 404 "not found in local store or registry" even though the build was visible in GET /skills/builds.

Extend resolveFromLocalStore so that when the direct tag lookup misses, or when a caller-supplied version disagrees with the direct match, it walks the local-build-marked tags for one whose declared skill name matches. The version filter accepts either the artifact's cfg.Version or the local store tag, mirroring the OCI-name install path that already treats version as the tag and matching the GET /skills/builds output where many artifacts carry a tag like "v0.0.1" with an empty SKILL.md version. With multiple matches, prefer the build whose tag equals the skill name; otherwise return 409 Conflict listing each candidate's tag and version.

Add table-driven cases covering: scan resolves by skill name when tag differs, version matches the local store tag (the user-facing reproducer), version filter narrows multiple matches, version mismatch falls through to registry, direct version mismatch falls through to scan, ambiguous matches return 409, and non-skill local-build-marked tags are ignored. Tighten the test runner so wantErr is also asserted when wantCode is set.

Coverage Stats

77 of 93 new or added lines in 1 file covered. (82.8%)

11 existing lines in 3 files now uncovered.

63076 of 97393 relevant lines covered (64.76%)

59.73 hits per line