rust-bitcoin / rust-bitcoin / 25445811858

82%

master: 83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#6136: backport: validate ASCII and preserve embedded nulls in CommandString parsing

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/ddb05e24e86431e31e3a952c26da547e3d9c7469">ddb05e24e fix: validate ASCII and preserve embedded nulls in CommandString parsing (Mitchell Bagot)

Pull request description:

  This is a backport of #4649.
  
  ---
  
  Previously, CommandString decoding would silently normalize invalid commands containing embedded null bytes. For example, "mem\0pool" would be incorrectly decoded as "mempool", bypassing consensus validation.
  
  Found through differential fuzzing between btcd and rust-bitcoin, where rust-bitcoin was accepting messages with embedded null bytes in Command fields while btcd (and Bitcoin Core) correctly reject them.
  
  Original author: Erick Cestari <erickcestari03@gmail.com>


ACKs for top commit:
  apoelstra:
    ACK ddb05e24e86431e31e3a952c26da547e3d9c7469; successfully ran local tests


Tree-SHA512: 74effd1d4042f478c36a4daa272e3bf311d

Coverage Stats

12 of 12 new or added lines in 1 file covered. (100.0%)

6 existing lines in 1 file now uncovered.

16495 of 20165 relevant lines covered (81.8%)

17665.52 hits per line