TTRPG-Dev / ex_ttrpg_dev / d8450436f7868d2000259166d7c6625aa8e8c654-PR-117

87%

main: 87%

Pull #117

github

feat(rule_module): error on missing required fields in concept_type and metadata_contribution

A [[concept_type]] entry without an id, or a [[metadata_contributions]]
entry without from_type/from_field/to_type/to_field/value, previously
produced a struct with nil fields that silently misbehaved: a nil id
would be included in the concept_type_ids MapSet, and a nil from_type
would cause the contribution to match no concepts and generate no
effects, with no indication of the problem.

from_map/1 now validates both lists before building the struct:
- validate_concept_types/1: {:error, {:concept_type_missing_id, idx}}
  if any entry lacks an id field.
- validate_metadata_contributions/1: {:error,
  {:metadata_contribution_missing_field, field, idx}} if any entry is
  missing one of the five required fields.

These return {:error, ...} from from_map/1 (and therefore from
Loader.load/1) rather than Logger.warning, because a metadata_contribution
with a nil from_type or a concept_type with a nil id cannot be recovered
from at runtime — the data is structurally invalid.

Restructured from_map/1 to use a top-level with/else rather than
if/else + nested with, eliminating a Credo nesting violation. Extracted
check_metadata_contribution_fields/1 to flatten the validate function
for the same reason.

26 of 26 new or added lines in 2 files covered. (100.0%)

1280 of 1477 relevant lines covered (86.66%)

10421.03 hits per line