25441711719

Committed 06 May 2026 02:31PM UTC coverage: 92.915%. Remained the same

Build # 25441711719

Build Type

push

github

Committed by

web-flow

Commit Message

use sha pin (with comment) format for generated actions (#23312)

Per the GitHub Action best practices we recently enabled at #23249, we
should pin each action to a SHA so that the reference is actually
immutable.

This will -- I hope -- knock out a large chunk of the 421 alerts we
currently get from zizmor. The next followup would then be upgrades and
harmonizing the generated and none-generated pins.

Notice: This idea was suggested by Claude while going over pinact output
and I was surprised to see that post processing the yaml wasn't too
gross.

Coverage Stats

92206 of 99237 relevant lines covered (92.91%)

4.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.65

/src/python/pants/backend/codegen/protobuf/tailor.py

# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

from dataclasses import dataclass

from pants.backend.codegen.protobuf.protoc import Protoc
from pants.backend.codegen.protobuf.target_types import ProtobufSourcesGeneratorTarget
from pants.core.goals.tailor import (
    AllOwnedSources,
    PutativeTarget,
    PutativeTargets,
    PutativeTargetsRequest,
)
from pants.engine.intrinsics import path_globs_to_paths
from pants.engine.rules import collect_rules, rule
from pants.engine.unions import UnionRule
from pants.util.dirutil import group_by_dir
from pants.util.logging import LogLevel


@dataclass(frozen=True)
class PutativeProtobufTargetsRequest(PutativeTargetsRequest):
    pass


@rule(level=LogLevel.DEBUG, desc="Determine candidate Protobuf targets to create")
async def find_putative_targets(
    req: PutativeProtobufTargetsRequest, all_owned_sources: AllOwnedSources, protoc: Protoc
) -> PutativeTargets:
    if not protoc.tailor:
        return PutativeTargets()

    all_proto_files = await path_globs_to_paths(req.path_globs("*.proto"))
    unowned_proto_files = set(all_proto_files.files) - set(all_owned_sources)
    pts = [
        PutativeTarget.for_target_type(
            ProtobufSourcesGeneratorTarget,
            path=dirname,
            name=None,
            triggering_sources=sorted(filenames),
        )
        for dirname, filenames in group_by_dir(unowned_proto_files).items()
    ]
    return PutativeTargets(pts)


def rules():
    return [
        *collect_rules(),
        UnionRule(PutativeTargetsRequest, PutativeProtobufTargetsRequest),
    ]

1	# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from __future__ import annotations	4✔
5
6	from dataclasses import dataclass	4✔
7
8	from pants.backend.codegen.protobuf.protoc import Protoc	4✔
9	from pants.backend.codegen.protobuf.target_types import ProtobufSourcesGeneratorTarget	4✔
10	from pants.core.goals.tailor import (	4✔
11	AllOwnedSources,
12	PutativeTarget,
13	PutativeTargets,
14	PutativeTargetsRequest,
15	)
16	from pants.engine.intrinsics import path_globs_to_paths	4✔
17	from pants.engine.rules import collect_rules, rule	4✔
18	from pants.engine.unions import UnionRule	4✔
19	from pants.util.dirutil import group_by_dir	4✔
20	from pants.util.logging import LogLevel	4✔
21
22
23	@dataclass(frozen=True)	4✔
24	class PutativeProtobufTargetsRequest(PutativeTargetsRequest):	4✔
25	pass	4✔
26
27
28	@rule(level=LogLevel.DEBUG, desc="Determine candidate Protobuf targets to create")	4✔
29	async def find_putative_targets(	4✔
30	req: PutativeProtobufTargetsRequest, all_owned_sources: AllOwnedSources, protoc: Protoc
31	) -> PutativeTargets:
32	if not protoc.tailor:	1✔
33	return PutativeTargets()	×
34
35	all_proto_files = await path_globs_to_paths(req.path_globs("*.proto"))	1✔
36	unowned_proto_files = set(all_proto_files.files) - set(all_owned_sources)	1✔
37	pts = [	1✔
38	PutativeTarget.for_target_type(
39	ProtobufSourcesGeneratorTarget,
40	path=dirname,
41	name=None,
42	triggering_sources=sorted(filenames),
43	)
44	for dirname, filenames in group_by_dir(unowned_proto_files).items()
45	]
46	return PutativeTargets(pts)	1✔
47
48
49	def rules():	4✔
50	return [	4✔
51	*collect_rules(),
52	UnionRule(PutativeTargetsRequest, PutativeProtobufTargetsRequest),
53	]

pantsbuild / pants / 25441711719

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous