• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stacklok / toolhive / 25439938257
65%

Build:
DEFAULT BRANCH: main
Ran 06 May 2026 02:05PM UTC
Jobs 1
Files 717
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 May 2026 01:59PM UTC coverage: 64.685% (-0.05%) from 64.733%
25439938257

push

github

web-flow
fix(api,cli): stop auto-deriving RFC 8707 resource indicator from URL (#5204)

* fix(api): stop auto-deriving RFC 8707 resource indicator from URL

The API path unconditionally derived the RFC 8707 resource parameter
from the server URL, while the CLI only did so when --resource-url was
explicitly passed. This broke OAuth for servers like Common Room that
don't support RFC 8707.

Remove the automatic URL-to-resource fallback in both
buildRemoteAuthConfigFromMetadata and createRequestToRemoteAuthConfig,
keeping only user-provided and metadata-provided resource values.

Fixes: #5203

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* test(api): add resource indicator tests for createRequestToRemoteAuthConfig

Verify that resource is NOT auto-derived from URL when not explicitly
set, and that an explicitly provided resource is preserved verbatim.
These tests guard against re-introducing the removed fallback derivation.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix(api,cli): remove auto-derivation of RFC 8707 resource from all paths

Also fix the CLI registry path (getRemoteAuthFromRemoteServerMetadata)
which had the same unconditional fallback to DefaultResourceIndicator.
Inline orphaned variable in createRequestToRemoteAuthConfig.

The resource parameter is now only set when explicitly provided by the
user or registry metadata, matching the behavior of the direct CLI path
which gates on --resource-url.

Refs: #5203

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore: address review nits — clarify comments

Add explanatory comment on registry path resource assignment
explaining why --resource-url derivation is intentionally skipped.
Reword test comment to be reader-facing rather than author-local.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

1 of 6 new or added lines in 2 files covered. (16.67%)

258 existing lines in 9 files now uncovered.

62877 of 97205 relevant lines covered (64.68%)

59.09 hits per line

Uncovered Changes

Lines Coverage ∆ File
5
31.78
-0.04% cmd/thv/app/run_flags.go

Coverage Regressions

Lines Coverage ∆ File
205
49.07
0.48% pkg/container/kubernetes/client.go
14
20.11
-8.05% pkg/client/manager.go
12
75.09
-4.33% pkg/client/config.go
12
67.9
-14.81% pkg/client/discovery.go
6
76.15
-5.5% pkg/secrets/keyring/keyctl_linux.go
3
70.0
-3.33% pkg/state/local.go
2
31.78
-0.04% cmd/thv/app/run_flags.go
2
93.94
-6.06% pkg/foreach/foreach.go
2
94.77
-1.31% pkg/vmcp/composer/dag_executor.go
Jobs
ID Job ID Ran Files Coverage
1 25439938257.1 06 May 2026 02:05PM UTC 717
64.68
GitHub Action Run
Source Files on build 25439938257
  • Tree
  • List 717
  • Changed 12
  • Source Changed 3
  • Coverage Changed 12
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #25439938257
  • ec284b0e on github
  • Prev Build on main (#25424148068)
  • Next Build on main (#25441337713)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc