peczenyj / GDPR-IAB-TCFv2 / 25437541712

96%

main: 96%

Build Type

push

github

Committed by web-flow

Commit Message

fix(cli): stop short -v from being shadowed by global --version|-V (#51)

bin/iabtcfv2's global Getopt::Long was configured with `:config
pass_through` only, leaving Getopt::Long's defaults (ignore_case ON,
no require_order) in effect.  That made `iabtcfv2 dump -v 284 <tc>`
behave as follows:

  1. Global GetOptions scans the entire @ARGV (no require_order).
  2. ignore_case matches `-v` against the `'version|V'` short
     alias case-insensitively.
  3. \$global_opts{version} flips on, the script prints the
     version string, and exits before `dump` is dispatched.

Adding `require_order` to the config makes the global GetOptions
stop scanning at the first non-option argument (`dump`), leaving
`-v 284 <tc>` for the subcommand's own GetOptionsFromArray to
parse — where `'vendor-id|v=i'` matches it correctly.

Regression test in t/09-predicates.t covers:
  - `dump -v <id> <tc>` does NOT print the version string
  - `dump -v 1 <tc>` produces the same vendor isolation as
    `dump --vendor-id 1 <tc>`

Verified locally that reverting the require_order change makes both
new assertions fail.

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

741 of 775 relevant lines covered (95.61%)

11586.79 hits per line