mroderick / codebar-planner / 25429409084

95%

master: 95%

push

github

fix: workshop capacity checks now properly compare attending count with available spaces

PR #2605 changed the capacity check methods from student_spaces?/
coach_spaces? to event_student_spaces?/event_coach_spaces?, but the
new methods in EventPresenter called model.student_spaces? which just
checks if the attribute is present (truthy), not if spaces are actually
available.

This fix adds proper event_student_spaces? and event_coach_spaces?
methods to WorkshopPresenter that correctly compare the number of
attending students/coaches with the available spaces from the workshop
model (using model.student_spaces and model.coach_spaces).

This ensures that:
- When 2 students attend a workshop with 2 spaces, event_student_spaces?
  returns false (correctly indicating the workshop is full)
- When 1 student attends a workshop with 2 spaces, event_student_spaces?
  returns true (correctly indicating space is available)

Fixes the bug where workshops showed as full even when spaces were
available, and vice versa.

4 of 4 new or added lines in 1 file covered. (100.0%)

3528 of 3696 relevant lines covered (95.45%)

47.28 hits per line