• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeovn / kube-ovn / 25428568791
25%

Build:
DEFAULT BRANCH: master
Ran 06 May 2026 10:01AM UTC
Jobs 1
Files 208
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 May 2026 09:57AM UTC coverage: 24.835% (-0.002%) from 24.837%
25428568791

push

github

web-flow
refactor(security): pass argv to exec instead of shell concatenation (#6700)

Three exec sites previously joined arguments into a single shell string
and ran them via "bash -c"/"sh -xc". Although every field reaching these
calls is currently validated (net.ParseIP, port ints, protocol whitelists),
the shell-concat pattern is fragile and was acknowledged with a TODO in
vpc_nat_gateway.go. Pass arguments directly as argv so the kubelet exec
API and os/exec deliver them without shell parsing.

- ovs_linux.go: split the UFO probe and disable into two direct ethtool
  exec calls. Treat probe failure as a best-effort skip to keep the prior
  shell behavior on devices/kernels that reject ``ethtool -k``.
- vpc_nat_gateway.go / service_lb.go: build an argv slice and pass it
  directly to ExecuteCommandInContainer; drop the existing TODO.
- nat-gateway.sh / lb-svc.sh: dispatch via ``shift`` + ``"\$@"``. Use
  ``"\$*"`` for nat-gateway.sh ``init`` so the documented
  ``init net1, net2`` form still works.

Inspired by flannel-io/flannel#2400.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 23 new or added lines in 3 files covered. (0.0%)

2 existing lines in 1 file now uncovered.

14074 of 56669 relevant lines covered (24.84%)

0.29 hits per line

Uncovered Changes

Lines Coverage ∆ File
17
0.33
-0.0% pkg/daemon/ovs_linux.go
3
0.0
0.0% pkg/controller/service_lb.go
3
3.31
0.0% pkg/controller/vpc_nat_gateway.go

Coverage Regressions

Lines Coverage ∆ File
2
3.31
0.0% pkg/controller/vpc_nat_gateway.go
Jobs
ID Job ID Ran Files Coverage
1 25428568791.1 06 May 2026 10:01AM UTC 208
24.84
GitHub Action Run
Source Files on build 25428568791
  • Tree
  • List 208
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 4b35ee76 on github
  • Prev Build on master (#25413412098)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc