babelfish-for-postgresql / babelfish_extensions / 25423728726
77%
BABEL_6_X_DEV: 78%

LAST BUILD BRANCH: BABEL-5975-PR1-full
DEFAULT BRANCH: BABEL_6_X_DEV
Ran
Jobs 1
Files 121
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 76.85% (+0.01%) from 76.839%
25423728726

push

github

web-flow 
Fix sql_variant type resolution in CASE, UNION, INTERSECT, EXCEPT, VALUES, and COALESCE expressions (#4795)

Expressions fail when sql_variant is mixed with other types in type-resolution contexts:

-- CASE: fails
SELECT CASE WHEN 1 = 1 THEN SERVERPROPERTY('IsFullTextInstalled') ELSE CAST(0 AS bit) END;
-- Error: CASE/WHEN could not convert type sql_variant to "bit"
-- COALESCE: fails
SELECT COALESCE(CAST(NULL AS sql_variant), CAST('hello' AS varchar(50)));
-- Error: COALESCE could not convert type sql_variant to "varchar"
The same class of issue affects UNION, INTERSECT, EXCEPT, and VALUES when sql_variant is mixed with non-char types.

Fix
select_common_type_setop - Added a pre-scan before the main loop: if any expression is sql_variant, return it immediately as the common type. This applies to all contexts routed through this function (CASE, UNION, INTERSECT, EXCEPT, VALUES). sql_variant has the highest TSQL precedence (0) and can hold any type, so it always wins.

select_common_type_for_coalesce_function - In the NULL-skipping logic, if the NULL arg's type is sql_variant, still consider it for precedence before continuing.

Both fixes use is_tsql_sqlvariant_datatype to narrowly target only sql_variant. No other types or code paths are affected.

select_common_type_for_coalesce_function also includes a minor cleanup: the UNKNOWNOID (string literal) handling was simplified by replacing ptype in-place and falling through to the shared precedence comparison, instead of duplicating the comparison inline with a separate continue. This is semantically equivalent and notstrictly required for the sql_variant fix.

Tasks:
BABEL-6402
BABEL-6427

cherry-picked from #4706

signed-off-by: Mohit Raj mrxmohit@amazon.com

53134 of 69140 relevant lines covered (76.85%)

615920.79 hits per line

Coverage Regressions

Lines Coverage ∆ File
85
87.19
 0.06% contrib/babelfishpg_tsql/src/pltsql_coerce.c
Jobs
ID Job ID Ran Files Coverage
1 25423728726.1 121
76.85
 GitHub Action Run
Source Files on build 25423728726