TTRPG-Dev / ex_ttrpg_dev / a26ce2c100bd18bbe75b327deb8b3f676017e3c9-PR-116

86%

main: 87%

Pull #116

github

feat(loader): warn on unknown concept metadata keys at load time

Previously, typos or undeclared keys in concept TOML silently had no
effect — the library ignored them without any feedback. This made it
easy to author broken config that appeared correct.

Now, `load/1` calls `warn_unknown_metadata_keys/3` after building the
concept_metadata map. Any key not in the allowed set emits a
Logger.warning grouped by {key, type_id} to avoid one warning per
concept. The warning names the system slug and lists the affected
concept IDs (first 5, then "+ N more").

Allowed keys are the union of four sources:
1. The structural vocabulary (@structural_metadata_keys) — the 18 keys
   the library reads by name from concept metadata.
2. metadata_contributions from_field and label_filters.filter_field
   values, which the loader expands into effects at load time.
3. inventory_rules dynamic keys (mode_field, pool_field,
   always_prepared_metadata_key, class_filter_field) — read by the
   evaluator at runtime from the InventoryRules config.
4. custom_metadata_keys declared in module.toml — the escape hatch for
   system authors who use domain-specific metadata keys that the
   library never reads (e.g. display metadata like "school",
   "casting_time", "description").

The dnd_5e_srd custom_metadata_keys list was built empirically by
running the integration test and iterating until zero warnings
remained, rather than enumerating by hand.

Warnings rather than errors to allow a smooth rollout. A future
breaking release can elevate these to errors once authors have had time
to migrate.

26 of 27 new or added lines in 1 file covered. (96.3%)

1255 of 1455 relevant lines covered (86.25%)

10312.39 hits per line