wboayue / rust-ibapi / 25402446613

92%

Build Type

push

github

Committed by web-flow

Commit Message

feat(connection): typed StartupMessage + StartupNoticeCallback (#513)

* feat(connection): typed StartupMessage + StartupNoticeCallback

Refactors ConnectionOptions::startup_callback from Fn(ResponseMessage) to
Fn(StartupMessage) with typed domain-object variants, and adds a separate
startup_notice_callback for handshake-time IB notices that were previously
log-only.

Fills the gap PR 5 (#512) did not address: notices like 2104/2106/2158
farm-status arrive during the handshake before process_messages starts, so
notice_stream never sees them. The new startup_notice_callback fires for
them inline.

Public API:
- StartupMessage = OpenOrder(OrderData) | OrderStatus(OrderStatus)
                 | OpenOrderEnd | AccountUpdate(AccountUpdate)
                 | Other(ResponseMessage)
- StartupMessageCallback = Box<dyn Fn(StartupMessage)>  (breaking; 3.0)
- StartupNoticeCallback  = Box<dyn Fn(Notice)>          (new)
- ConnectionOptions::startup_notice_callback(...) builder

Both callbacks now persist on Connection<S>/AsyncConnection<S> and fire on
auto-reconnect handshakes too (previously the existing callback was hardcoded
to None on reconnect).

Internal cleanup:
- parse_account_info reduced to NextValidId/ManagedAccounts; everything else
  delegated to a new dispatch_unsolicited_message free fn (SRP split).
- StartupCallbacks<'a> bundles both callbacks for threading (project rule:
  max 3 fn args).
- decode_*_either helpers in orders/accounts decoder modules pick proto-vs-text.

Tests: sync 943 lib + async 945 lib + all-features 1155 lib + 74 doc.
Live-gateway diagnostic confirmed OpenOrderEnd lands as the typed variant.
Clippy clean across default, sync-only, and --all-features.

* refactor(connection): reuse decode_error_envelope for handshake notices

The handshake-time Error decoder in connection/common.rs duplicated the
protobuf ErrorMessage decode that already lives in transport/routing.rs.
Worse: the handshake version dropped error_time (set to None... (continued)

Coverage Stats

104 of 145 new or added lines in 6 files covered. (71.72%)

2 existing lines in 2 files now uncovered.

17268 of 19651 relevant lines covered (87.87%)

26.86 hits per line