stephenafamo / bob / 25401742820

44%

main: 44%

Build Type

Pull #668

github

Committed by Roman A. Grigorovich

Commit Message

fix(gen): add missing base type imports in ToOptional and FromOptional

Functions ToOptional and FromOptional were discarding the second return
value from getOptional(), which carries the base type imports (e.g.
"github.com/google/uuid"). This caused generated code to reference
types without importing their package.

The bug manifested in M2M relationships where a join-table attach
function referenced a column type from a remote table. For example,
attachRoleUsers0 in roles.bob.go used uuid.UUID from the users table
but the import was never added to roles.bob.go.

Fix: capture the imports slice returned by getOptional and pass it
to the importer before the expression-specific imports.

Pull Request Pull Request #668: fix(gen): add missing base type imports in ToOptional and FromOptional

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

8 existing lines in 1 file now uncovered.

10627 of 24021 relevant lines covered (44.24%)

595.6 hits per line