IQSS / dataverse-frontend / 25399700271

98%

develop: 97%

Build Type

Pull #898

github

Committed by ErykKul

Commit Message

Fix the four remaining component-test failures

Component CI was red on:

- FilesTree.spec.tsx - 'renders empty state when no files are
  present': matcher was /no files/i. Both 'No files selected'
  (toolbar) and 'This dataset has no files' (state) match it, so
  cy.findByText fails with 'Found multiple elements'. Tightened to
  /this dataset has no files/i.

- FileUploader.spec.tsx 'replace mode' x2 + 'add files' x1: the
  'shows unknown error message in toast' tests fail because
  Sinon.stub().rejects() with no argument resolves to a plain
  Error('Error'), and the catch block in useReplaceFile.ts /
  useAddUploadedFilesToDataset.ts checks `if (writeError &&
  (writeError.reason || writeError.message))`. A plain Error has
  .message so the WriteError-specific branch fires and toasts
  'Error' instead of falling to the generic default. Fix: use
  `err instanceof WriteError` instead — only the actual
  JSDataverse WriteError class triggers the format-via-handler
  path. Plain Errors fall to the user-friendly default toast.

- FileUploader.spec.tsx 'renders file upload by clicking add
  button': cy.get('input[type=file]').selectFile(...) fails with
  'subject contained 2 elements'. The drop zone now renders both a
  regular file input and a folder input ([webkitdirectory]) since
  the folder-selection feature landed. The selector matched both.
  Targeted only the file input via :not([webkitdirectory]).

The three e2e failures (FileUpload DirectUpload 403, Login
OIDC sign-up timeout, Dataset 'Unrestrict' text not found) are
all in spec files we don't touch; they're CI backend / OIDC
fixture issues unrelated to this slice — leaving for whoever
maintains those flows.

Pull Request Pull Request #898: Add reusable React components: file uploader and file tree view

Coverage Stats

1578 of 1634 branches covered (96.57%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 3 files covered. (100.0%)

23 existing lines in 12 files now uncovered.

3789 of 3839 relevant lines covered (98.7%)

10902.77 hits per line