rust-bitcoin / rust-bitcoin / 25397991914

82%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#6106: backport: Fix Unknown NetworkMessage encoding

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/be1dc059e0671398c4fe2a8de13ffc6358bfd710">be1dc059e backport: Fix Unknown NetworkMessage encoding (Mitchell Bagot)

Pull request description:

  This is a backport of #5671, with adjustments to the test case to handle the lack of encoding::Decoder types.
  
  ---
  
  The old Encodable implementation for NetworkMessage make use of the Vec<u8> encoding for the raw payload data. This introduces a vector length prefix to the start of the encoding which causes the roundtrip for Unknown NetworkMessage types to fail. In practice, NetworkMessage will only ever be decoded through the RawNetworkMessage, where a payload length will be known. As such, this length prefix is not necessary in the encoding and can be trivially removed.
  
  Change Unknown NetworkMessage encoding to directly write the vector of bytes instead of using Vec<u8> encoding logic.


ACKs for top commit:
  tcharding:
    ACK be1dc059e0671398c4fe2a8de13ffc6358bfd710
  apoelstra:
    ACK be1dc059e0671398c4fe2a8de13ffc6358bfd710; successfully ran local tests


Tree-SHA512: 92a3ae9730698af4226815af2b071a832a5

10 of 10 new or added lines in 1 file covered. (100.0%)

16497 of 20162 relevant lines covered (81.82%)

17569.32 hits per line