dcdpr / jp / 25392492630

65%

Build Type

push

github

Committed by web-flow

Commit Message

feat(config, cli): Add `FormatMode` for pre-approval tool rendering (#597)

Introduces a `format` config field (values: `ask` | `unattended`) for
both per-tool and global tool defaults, controlling when a tool's
argument formatter runs relative to the approval prompt.

Previously, the formatter always ran after the user approved a tool
call. With `format = "unattended"`, the formatter fires before the
approval prompt, so the user sees the rendered tool call (not raw JSON
arguments) when deciding whether to approve.

The mode can be set explicitly in config:

    [conversation.tools."my-tool"]
    run = "ask"
    format = "unattended"

When `format` is unset, it is derived from `run`: `Ask`/`Edit`/`Skip`
map to `FormatMode::Ask` (safe default — formatter only runs after
explicit approval); `Unattended` maps to `FormatMode::Unattended`
(formatter can run freely, since the tool was already going to run
without an approval prompt anyway).

The `ToolCoordinator` gains three new methods to encapsulate this logic:
`format_mode`, `pre_render_for_prompt`, and
`resolve_tool_call_decision`. The latter consolidates the full decide →
pre-render → prompt → apply → post-render pipeline into a single seam,
so future permission-related features (telemetry, sandboxing, alternate
prompt modes) apply uniformly to both the streaming path and the
batch/restart path.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

6 of 101 new or added lines in 2 files covered. (5.94%)

1 existing line in 1 file now uncovered.

24655 of 38349 relevant lines covered (64.29%)

180.68 hits per line