dcdpr / jp / 25387974517

66%

Build Type

push

github

Committed by web-flow

Commit Message

fix(tool, inquire): Split question preamble from prompt text (#595)

Multi-line `Question::text` values caused garbled terminal output when
rendered through `inquire`'s `InlineSelect`. The underlying primitive
tracks line counts for terminal redraws assuming a single-line message,
so embedding a diff or patch directly in `text` caused it to under-count
lines and leave stray content on screen.

The fix introduces a dedicated `pre_amble` field on `Question` for
multi-line content that should appear before the prompt. The `text`
field is now documented to be a single line. `InlineSelect` and
`ToolPrompter` both emit the preamble independently before handing the
single-line `text` to inquire.

To make this constraint easier to enforce and the construction less
error-prone, `Question` gains a builder-style API — `Question::text()`,
`Question::boolean()`, and `Question::select()` constructors paired with
`with_preamble()`, `with_default()`, `with_options()`, and
`with_option()` combinators. The struct is also marked
`#[non_exhaustive]` to prevent callers from constructing it with struct
literals, which would bypass the single-line `text` invariant.

All existing call-sites in the project tools and test code have been
updated to use the new API.

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

71 of 109 new or added lines in 8 files covered. (65.14%)

5 existing lines in 4 files now uncovered.

24613 of 38201 relevant lines covered (64.43%)

216.28 hits per line