extphprs / ext-php-rs / 25381118290

72%

master: 66%

Build Type

Pull #734

github

Committed by ptondereau

Commit Message

fix(builders): wrap noop_handler in zend_fastcall! for windows

The cfg(php83) test helper noop_handler in src/builders/function.rs
was declared as `extern "C"`, which only matches FunctionHandler on
unix. On windows the type alias is `extern "vectorcall"`, so the
class_union, intersection, and DNF return-type tests failed to
type-check there with E0308 ("expected vectorcall fn, found C fn").

Wrap noop_handler in zend_fastcall! { ... } the same way closure.rs
and builders/class.rs do. The macro rewrites the ABI to vectorcall
on windows and stays C on unix.

Also drop the redundant `#![cfg_attr(windows, feature(abi_vectorcall))]`
inside src/describe/mod.rs's tests module. Inner `feature` attributes
only take effect at the crate root, so this was a no-op that produced
"the `#![feature]` attribute can only be used at the crate root"
on every windows compile. The crate root already enables the feature
in src/lib.rs.

Pull Request Pull Request #734: feat!: PHP 8 union, intersection, DNF, and class-union type hints

Coverage Stats

2871 of 3074 new or added lines in 21 files covered. (93.4%)

3 existing lines in 2 files now uncovered.

11514 of 15886 relevant lines covered (72.48%)

33.34 hits per line