Teamwork / kommentaar / 25378422108

53%

master: 53%

Build Type

push

github

Committed by web-flow

Commit Message

Fix package name collision when two packages share the same base name (#111)

* Fix package name collision when two packages share the same base name

When two packages have the same last path component (e.g. sub-a/shared
and sub-b/shared both resolve to "shared"), GetReference was using
filepath.Base(pkg) as the lookup key, causing the second type to
silently overwrite the first in prog.References.

The fix adds a collision check before storing: if the key already exists
for a different package, a numeric suffix is appended (shared.Request2,
shared.Request3, …) to produce a unique key. Repeated calls for the same
colliding package reuse the existing suffixed key.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Extract applyFieldWhitelists to reduce GetReference cyclomatic complexity

GetReference exceeded the gocyclo threshold of 65 (was 68). Extracting the
field-whitelist processing block into its own helper brings it back under
the limit without changing behaviour.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

11 of 47 new or added lines in 1 file covered. (23.4%)

7 existing lines in 1 file now uncovered.

1169 of 2204 relevant lines covered (53.04%)

44.98 hits per line