dunglas / mercure / 25375313499
84%
master: 93%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 1
Files 24
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.89%. Remained the same
25375313499

Pull #1240

github

dunglas 
ci: lint the caddy module too, fix the issues it surfaces

The caddy/ submodule was not covered by golangci-lint in CI. Wire it into
the workflow with the same config and timeout, and clean up the issues that
surfaced once it ran.

Notable changes in caddy/:

- normalize Bolt, Local, Health, Mercure to pointer receivers everywhere
  (recvcheck), and register the modules as &T{} so the interface is still
  satisfied
- move the embedded deprecatedTransport before the regular Mercure fields
  (embeddedstructfieldcheck) and reorder populateJWTConfig and
  newJWKSetKeyfunc after the public methods (funcorder)
- parse subscriber_list_cache_size with strconv.Atoi to drop an unchecked
  uint64 -> int conversion (gosec G115), and reject negative values with a
  Caddyfile error so they do not propagate into NewSubscriberList
- rephrase the AllowNoPublish and FindHub doc comments so they start with
  the symbol name (godoclint)
- nolint a handful of remaining cases that are intentional (deprecated
  shim returning nil,nil; deprecated mercure.NewTransport call gated by
  the deprecated_transport build tag; Provision complexity; ArgErr/WrapErr
  passthrough in parseDurationParameter; newJWKSetKeyfunc returning the
  keyfunc.Keyfunc interface)

The local replace directive in caddy/go.mod is required for the submodule
to resolve the parent package, so gomoddirectives is configured to allow
local replacements rather than excluded per-line.
Pull Request #1240: ci: lint the caddy module too, fix the issues it surfaces

1807 of 2154 relevant lines covered (83.89%)

49.65 hits per line

Jobs
ID Job ID Ran Files Coverage
1 0 - 25375313499.1 24
83.89
 GitHub Action Run
Source Files on build 25375313499