opendefensecloud / solution-arsenal / 25368188389
72%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 31
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 70.607%. Remained the same
25368188389

push

github

web-flow 
fix(api): add missing listType markers to Conditions fields (#493)

## What
Add missing `+listType=map` / `+listMapKey=type` markers to `Conditions`
fields in `ReleaseStatus` and `RenderTaskStatus`.

## Why
`make codegen` generates `client-go/openapi/api_violations.report`. Two
`list_type_missing` violations were reported for our namespace — all
other status types in the package (`TargetStatus`, `ProfileStatus`,
`RegistryStatus`, etc.) already carry these markers; `ReleaseStatus` and
`RenderTaskStatus` were just missed.

## Testing
Run `make codegen` and verify no `list_type_missing` entries remain for
`go.opendefense.cloud/solar` in
`client-go/openapi/api_violations.report`.

## Checklist
- [x] ~~Tests added/updated~~ markers are validated by `make codegen`
:arrow_right: see diff in violations report
  - [x] No breaking changes (or upgrade path documented above)
  - [x] Readable commit history (squashed and cleaned up as desired)
  - [x] AI code review considered and comments resolved

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Enhanced Kubernetes API resource schema metadata to improve list
merging and patching behavior in status definitions.
* Updated OpenAPI specifications to align with Kubernetes best practices
for list type handling.
  * Resolved API schema compliance violations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

2258 of 3198 relevant lines covered (70.61%)

19.47 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
63.83
 -0.67% pkg/controller/target_controller.go
2
74.42
 -0.78% pkg/controller/profile_controller.go
Jobs
ID Job ID Ran Files Coverage
1 25368188389.1 31
70.61
 GitHub Action Run
Source Files on build 25368188389