kubernetes-sigs / ibm-vpc-block-csi-driver / 25363355092

73%

Build Type

push

github

Committed by web-flow

Commit Message

Fixed formatting issue in case device path does not exists (#254)

* Fixed formatting issue in case device path does not exists and udevadm fail to refresh device

Signed-off-by: Arashad Ahamad <arahamad@in.ibm.com>

* Add Linux-specific build support and fix critical Dockerfile dependencies

- Add separate build targets for Linux and macOS in Makefile
- Fix missing critical filesystem utilities in Dockerfile (util-linux, e2fsprogs, mount)
- Add dependency verification layer to fail build if required commands are missing
- Improve findDevicePathSource with better error handling and device path validation
- Enhance udevadmTrigger with proper error messages and device refresh logic
- Update udevadmTrigger to use mounter's executor for better testability
- Add UDEVADM_SLEEP_DURATION environment variable for test optimization
- Update unit tests with proper mocking for cross-platform compatibility
- Remove non-existent GetDiskFormat() call from node.go

This ensures the CSI driver has all required commands for FormatAndMount operations:
- blkid (filesystem detection)
- mkfs.ext2/3/4 (ext filesystem formatting)
- fsck (filesystem check/repair)
- resize2fs (filesystem resizing)
- mount/umount (mount operations)
- mkfs.xfs, xfs_repair, xfs_growfs (XFS support)
- udevadm (device discovery)

Improvements to device path handling:
- Better validation of device paths before formatting operations
- Clear error messages when device paths are not found
- Proper handling of udevadm trigger failures
- Prevention of formatting operations on non-existent devices

* Fix GitHub Actions to use pinned commit SHAs

- Pin actions/setup-go@v2 to commit SHA 93397bea1 (v2.2.0)
- Pin actions/checkout@v2 to commit SHA ec3a7ce11 (v2.6.0)

This resolves the CI/CD error requiring all actions to be pinned to full-length commit SHAs
for security compliance in kubernetes-sigs repositories.

* Improve test coverage for findDev... (continued)

Coverage Stats

89 of 150 new or added lines in 2 files covered. (59.33%)

41 existing lines in 2 files now uncovered.

1462 of 2002 relevant lines covered (73.03%)

13.03 hits per line