KarpelesLab / goro / 25354859519

13%

push

github

vm: native class const / static / ::class access

Adds OP_CLASS_CONST and a SubASTs side-table on Function.
The opcode delegates to the AST runner for the four
class-level access node types: *runClassDynConst (the
\$obj->class form), *runClassStaticObjRef (Foo::CONST and
Foo::method), *runClassStaticVarRef (Foo::\$bar), and
*runClassNameOf (Foo::class).

Constant resolution involves CompileDelayed expressions,
visibility checks (private/protected with caller-class
verification), interface and parent walking, and the
[constant expression] decoration on rethrown errors —
all 200+ lines of intricate logic. Lowering each piece
into bytecode would duplicate that code; delegating the
whole node is correct, simple, and isolated to a single
opcode that does Run() on the embedded AST.

This is the same pattern OP_MAKE_CLOSURE already uses for
*ZClosure (which has its own dup + capture + Spawn flow).
The two side tables (SubClosures, SubASTs) keep the
delegation typed so OP_CLASS_CONST can never grow into a
generic AST fallback.

phpt under GORO_VM=1: 14 regressions (unchanged — these
tests already passed via AST fall-back since the function
bodies use other unsupported features alongside class
const access; the new opcode unblocks more code that
previously fell back).

Bench unchanged at the macro level (none of the
benchmarks use class constants).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

27 of 35 new or added lines in 4 files covered. (77.14%)

10519 of 114864 relevant lines covered (9.16%)

1099.54 hits per line